[ 
https://issues.apache.org/jira/browse/KAFKA-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576402#comment-15576402
 ] 

ASF GitHub Bot commented on KAFKA-4303:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/2031

    KAFKA-4303: Ensure commitSync does not block indefinitely in poll without 
in-flight requests

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-4303

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2031
    
----
commit ccba1a4ee7626230d9a6aed1e966d54d6e509c26
Author: Jason Gustafson <ja...@confluent.io>
Date:   2016-10-14T20:29:06Z

    KAFKA-4303: Ensure commitSync does not block indefinitely in poll without 
in-flight requests

----


> KafkaConsumer hangs indefinitely in commitSync() 
> -------------------------------------------------
>
>                 Key: KAFKA-4303
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4303
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Blocker
>             Fix For: 0.10.1.0
>
>
> This appears to be a regression caused by the KIP-62 patch. It is possible 
> that we end up blocking indefinitely in {{NetworkClient.poll()}} with no 
> requests pending. The reason is that 
> {{ConsumerNetworkClient.poll(RequestFuture)}} does not actually verify that 
> the request has been sent prior to calling {{NetworkClient.poll()}}. This was 
> not possible previously because the maximum timeout was always bounded by the 
> heartbeat interval.
> This appears to be the cause of hanging builds that some people may have 
> experienced. In particular, I have seen {{ConsumerBounceTest}} hang because 
> of this problem.
> Note that another reason we can block indefinitely in {{commitSync()}} is 
> coordinator discovery. We do not attempt to fix this here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to