ASF GitHub Bot commented on KAFKA-4161:

GitHub user shikhar opened a pull request:


    KAFKA-4161: prototype for exploring API change


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shikhar/kafka kafka-4161

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2040
commit ed75ad7b5618aff9fc85573748c23a5229144bc3
Author: Shikhar Bhushan <shik...@confluent.io>
Date:   2016-10-18T19:50:28Z

    KAFKA-4161: prototype for exploring API change


> Decouple flush and offset commits
> ---------------------------------
>                 Key: KAFKA-4161
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4161
>             Project: Kafka
>          Issue Type: New Feature
>          Components: KafkaConnect
>            Reporter: Shikhar Bhushan
>            Assignee: Ewen Cheslack-Postava
>              Labels: needs-kip
> It is desirable to have, in addition to the time-based flush interval, volume 
> or size-based commits. E.g. a sink connector which is buffering in terms of 
> number of records may want to request a flush when the buffer is full, or 
> when sufficient amount of data has been buffered in a file.
> Having a method like say {{requestFlush()}} on the {{SinkTaskContext}} would 
> allow for connectors to have flexible policies around flushes. This would be 
> in addition to the time interval based flushes that are controlled with 
> {{offset.flush.interval.ms}}, for which the clock should be reset when any 
> kind of flush happens.
> We should probably also support requesting flushes via the 
> {{SourceTaskContext}} for consistency though a use-case doesn't come to mind 
> off the bat.

This message was sent by Atlassian JIRA

Reply via email to