Thanks for catching that and the fix as well. Makes sense to me. We should consider adding an "amendments" section to KIPs - perhaps just a link to KAFKA-4313 would suffice in this case.
Thanks, Joel On Wed, Oct 19, 2016 at 7:12 PM, Jun Rao <j...@confluent.io> wrote: > Hi, > > While testing KIP-73, we found an issue described in > https://issues.apache.org/jira/browse/KAFKA-4313. Basically, when there > are > mixed high-volume and low-volume partitions, when replication throttling is > specified, ISRs for those low volume partitions could thrash. KAFKA-4313 > fixes this issue by avoiding throttling those replicas in the throttled > replica list that are already in sync. Those in-sync replicas traffic will > still be accounted for the throttled traffic though. Just want to bring > this up since it slightly changes the behavior described in the KIP. If > anyone has concerns on this, please comment on the jira. > > Thanks, > > Jun > > On Tue, Aug 23, 2016 at 3:25 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > > For the record, there were 4 binding +1s. > > > > Ismael > > > > On Tue, Aug 23, 2016 at 11:16 PM, Ben Stopford <b...@confluent.io> wrote: > > > > > Thanks everyone. It looks like this KIP has now been accepted. > > > > > > There is a corresponding PR <https://github.com/apache/kafka/pull/1776 > > > > > for the implementation also. > > > > > > All the best > > > > > > B > > > > > > > > > > On 23 Aug 2016, at 22:39, Joel Koshy <jjkosh...@gmail.com> wrote: > > > > > > > > +1 > > > > (sent some very minor edits to you off-thread) > > > > > > > > On Fri, Aug 19, 2016 at 1:21 AM, Ben Stopford <b...@confluent.io> > > wrote: > > > > > > > >> I’d like to initiate the voting process for KIP-73: > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > >> 73+Replication+Quotas <https://cwiki.apache.org/ > > > >> confluence/display/KAFKA/KIP-73+Replication+Quotas> > > > >> > > > >> Ben > > > > > > > > >
