GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/2103

    KAFKA-4379: Remove caching of dirty and removed keys from StoreChangeLogger

    The `StoreChangeLogger` currently keeps a cache of dirty and removed keys 
and will batch the changelog records such that we don't send a record for each 
update. However, with KIP-63 this is unnecessary as the batching and de-duping 
is done by the caching layer. Further, the `StoreChangeLogger` relies on 
`context.timestamp()` which is likely to be incorrect when caching is enabled

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka store-change-logger

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2103
    
----
commit 9acd0cf3521b9fabec7b53fe147f445a6bf82b5a
Author: Damian Guy <damian....@gmail.com>
Date:   2016-11-04T12:36:59Z

    remove caching from StoreChangeLogger

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to