[
https://issues.apache.org/jira/browse/KAFKA-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649605#comment-15649605
]
ASF GitHub Bot commented on KAFKA-4393:
---------------------------------------
GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/2117
KAFKA-4393: Improve invalid/negative TS handling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka
kafka-4393-improveInvalidTsHandling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2117
----
commit 23e08d18585febdf34917e1d33f4c142ae36e748
Author: Matthias J. Sax <[email protected]>
Date: 2016-11-09T02:01:56Z
KAFKA-4393: Improve invalid/negative TS handling
----
> Improve invalid/negative TS handling
> ------------------------------------
>
> Key: KAFKA-4393
> URL: https://issues.apache.org/jira/browse/KAFKA-4393
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Fix For: 0.10.2.0
>
>
> Currently, Kafka Streams does not handle invalid/negative timestamps returned
> from the {{TimestampExtractor}} gracefully, but fails with an exception,
> because negative timestamps cannot get handled in a meaningful way for any
> time based (ie, window) operators like window aggregates and joins.
> We want to change Stream to a auto-drop behavior for negative timestamps for
> those records (without any further user notification about dropped record)
> instead of an exception. To guard the user from silently dropping messages
> (and kept current fail-fast behavior), we change the default extractor
> {{ConsumerRecordTimestampExtractor}} to check the extracted meta-data record
> timestamp and raise an exception if it is negative. Furthermore, we add a
> "drop-and-log" extractor, as this seems to be a common behavior user might
> want to have. For any other behavior, users can still provide a custom
> TS-Extractor implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
