[
https://issues.apache.org/jira/browse/KAFKA-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657007#comment-15657007
]
ASF GitHub Bot commented on KAFKA-4359:
---------------------------------------
GitHub user enothereska opened a pull request:
https://github.com/apache/kafka/pull/2124
KAFKA-4359: Removed commit interval
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enothereska/kafka
KAFKA-4359-intergration-tests-commit1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2124
----
commit eab63b569f21797bd502c520341f5d90fbc6d9db
Author: Eno Thereska <eno.there...@gmail.com>
Date: 2016-11-11T12:51:10Z
Removed commit interval
----
> Streams integration tests should not use commit interval of 1
> -------------------------------------------------------------
>
> Key: KAFKA-4359
> URL: https://issues.apache.org/jira/browse/KAFKA-4359
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 0.10.1.1
> Reporter: Eno Thereska
> Assignee: Eno Thereska
> Fix For: 0.10.1.1
>
>
> Several streams integration tests use two cache sizes, 0 and 10MB. However,
> when they use 10MB, they still use a very small commit interval (1ms). That
> leads to two problems:1) a small commit interval often has the same effect as
> having the cache size be 0, and 2) a small commit interval is not exactly the
> same as the cache size being 0 and in some cases there is deduplication. This
> leads to the tests failing, since they don't expect deduplication.
> To solve this issue, look at KStreamAggregationDedupIntegrationTest and
> KStreamAggregationIntegrationTest. If you want to test dedup, it would be
> necessary to create another file.
> Several tests need this cleanup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
