small nitpick - given that s,t,k and i are used as part of a rather large CSV format, what is the gain in having them be single letter aliases? in other words - why not salt=... , serverKey=... , storedKey=... , iterations=... ?
On Tue, Nov 15, 2016 at 7:26 AM, Mickael Maison <mickael.mai...@gmail.com> wrote: > +1 > > On Tue, Nov 15, 2016 at 10:57 AM, Rajini Sivaram > <rajinisiva...@googlemail.com> wrote: > > Jun, > > > > Thank you, I have made the updates to the KIP. > > > > On Tue, Nov 15, 2016 at 12:34 AM, Jun Rao <j...@confluent.io> wrote: > > > >> Hi, Rajini, > >> > >> Thanks for the proposal. +1. A few minor comments. > >> > >> 30. Could you add that the broker config sasl.enabled.mechanisms can now > >> take more values? > >> > >> 31. Could you document the meaning of s,t,k,i used in > /config/users/alice > >> in ZK? > >> > >> 32. In the rejected section, could you document why we decided not to > bump > >> up the version of SaslHandshakeRequest? > >> > >> Jun > >> > >> > >> On Mon, Nov 14, 2016 at 5:57 AM, Rajini Sivaram < > >> rajinisiva...@googlemail.com> wrote: > >> > >> > Hi all, > >> > > >> > I would like to initiate the voting process for *KIP-84: Support > >> SASL/SCRAM > >> > mechanisms*: > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >> > 84%3A+Support+SASL+SCRAM+mechanisms > >> > > >> > This KIP adds support for four SCRAM mechanisms (SHA-224, SHA-256, > >> SHA-384 > >> > and SHA-512) for SASL authentication, giving more choice for users to > >> > configure security. When delegation token support is added to Kafka, > >> SCRAM > >> > will also support secure authentication using delegation tokens. > >> > > >> > Thank you... > >> > > >> > Regards, > >> > > >> > Rajini > >> > > >> > > > > > > > > -- > > Regards, > > > > Rajini >