[
https://issues.apache.org/jira/browse/KAFKA-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702638#comment-15702638
]
ASF GitHub Bot commented on KAFKA-4439:
---------------------------------------
GitHub user cmccabe opened a pull request:
https://github.com/apache/kafka/pull/2180
KAFKA-4439: NetworkClient: create a builder class to encapsulate ctor
arguments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmccabe/kafka KAFKA-4439
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2180
----
commit b501ad097e41f6b99ffa47ccbaf4f7fbbcbc9df8
Author: Colin P. Mccabe <[email protected]>
Date: 2016-11-24T01:31:18Z
KAFKA-4439: NetworkClient: create a builder class to encapsulate the many
arguments to the constructor
----
> Add a builder to NetworkClient
> ------------------------------
>
> Key: KAFKA-4439
> URL: https://issues.apache.org/jira/browse/KAFKA-4439
> Project: Kafka
> Issue Type: Improvement
> Components: network
> Reporter: Colin P. McCabe
> Priority: Minor
>
> NetworkClient's constructors have too many parameters. This makes it hard to
> follow what each value is being initialized to. Instead, let's use the
> builder pattern to clearly identify what each parameter is and provide
> sensible defaults for each.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
