Hi Jason, Thanks for the feedback. I believe the proposal now covers what you're suggesting. I also like the AdminClient option better, and that what made me update the KIP to take that approach, and suggest the modification to OffsetFetch protocol as you pointed out.
I'll wait until Monday, and then put it up for a vote if no concern is raised by then. Regards, --Vahid From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 11/30/2016 04:00 PM Subject: Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update Hey Vahid, Sorry to getting to this so late. I don't have a strong preference for keeping it out of the KafkaConsumer API. Having a no-arg committed() method which returns all the committed offsets seems natural and could be useful. Since no one has asked for it, however, I'd lean toward supporting this functionality only in the AdminClient, which appears to be what you chose. If that's the case, then the only public API change here is that OffsetFetchRequest can accept null for the list of partitions, which seems reasonable. I also think it's a nice improvement not to have to create the "dummy" consumer to lookup offsets. Since this KIP has been out for a while, maybe put it to a vote if no one else has feedback in the next couple days? Thanks, Jason On Tue, Nov 15, 2016 at 12:58 PM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Hi Jason, > > I updated the KIP one more time to make use of AdminClient to access the > updated API. > I made a note of the previous two versions of the KIP under "Rejected > Alternatives". > > Thanks. > --Vahid > > > > From: Vahid S Hashemian/Silicon Valley/IBM@IBMUS > To: dev@kafka.apache.org > Date: 11/09/2016 11:21 AM > Subject: Re: [DISCUSS] KIP 88: OffsetFetch Protocol Update > > > > Jason, > For some reason I did not receive your earlier response to the thread. > I just saw it when I went to > https://www.mail-archive.com/dev@kafka.apache.org/msg59608.html > In the updated KIP I exposed the capability via KafkaConsumer (your first > suggestion), but would be happy to look into adding it to AdminClient in > the next round if you think that's the better approach. > Thanks. > --Vahid > > > > > > > > > > > > >
