[ 
https://issues.apache.org/jira/browse/KAFKA-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733704#comment-15733704
 ] 

ASF GitHub Bot commented on KAFKA-3008:
---------------------------------------

GitHub user shikhar opened a pull request:

    https://github.com/apache/kafka/pull/2232

    HOTFIX: Fix HerderRequest.compareTo()

    With KAFKA-3008 (#1788), the implementation does not respect the contract 
that 'sgn(x.compareTo(y)) == -sgn(y.compareTo(x))'
    
    This fix addresses the hang with JDK8 in DistributedHerderTest.compareTo()

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shikhar/kafka herderreq-compareto

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2232
    
----
commit 4c5a8102a340478509a1c9331bf53ceccac394fb
Author: Shikhar Bhushan <shik...@confluent.io>
Date:   2016-12-08T23:18:59Z

    HOTFIX: Fix HerderRequest.compareTo()
    
    With KAFKA-3008 (#1788), the implementation does not respect the contract 
that 'sgn(x.compareTo(y)) == -sgn(y.compareTo(x))'
    
    This fix addresses the hang with JDK8 in DistributedHerderTest.compareTo()

----


> Connect should parallelize task start/stop
> ------------------------------------------
>
>                 Key: KAFKA-3008
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3008
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 0.9.0.0
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Konstantine Karantasis
>            Priority: Minor
>             Fix For: 0.10.2.0
>
>
> The Herder implementations currently iterate over all connectors/tasks and 
> sequentially start/stop them. We should parallelize this. This is less 
> critical for {{StandaloneHerder}}, but pretty important for 
> {{DistributedHerder}} since it will generally be managing more tasks and any 
> delay starting/stopping a single task will impact every other task on the 
> node (and can ultimately result in incorrect behavior in the case of a single 
> offset commit in one connector taking too long preventing all of the rest 
> from committing offsets).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to