GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/2249
KAFKA-4473: RecordCollector should handle retriable exceptions more strictly
The `RecordCollectorImpl` currently drops messages on the floor if an
exception is non-null in the producer callback. This will result in message
loss and violates at-least-once processing.
Rather than just log an error in the callback, save the exception in a
field. On subsequent calls to `send`, `flush`, `close`, first check for the
existence of an exception and throw a `StreamsException` if it is non-null.
Also, in the callback, if an exception has already occurred, the `offsets` map
should not be updated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-4473
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2249
----
commit 9ceaa67a9967edfa7522bb9daea64c1bc44738c0
Author: Damian Guy <damian....@gmail.com>
Date: 2016-12-12T17:47:27Z
throw exception in record collector instead of just dropping messages on
the floor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
