Thanks for the KIP. A few comments: 1. The suggestion is to use the JAAS config value as the key to the map in `LoginManager`. The config value can include passwords, so we could potentially end up leaking them if we log the keys of `LoginManager`. This seems a bit dangerous.
2. If someone uses the same JAAS config value in two clients, they'll get the same `JaasConfig`, which seems fine, but worth mentioning (it means that the `JaasConfig` has to be thread-safe). 3. How big can a JAAS config get? Is it an issue to use it as a map key? Probably not given how this is used, but worth covering in the KIP as well. Ismael On Tue, Sep 27, 2016 at 10:15 AM, Edoardo Comar <eco...@uk.ibm.com> wrote: > Hi, > I had a go at a KIP that addresses this JIRA > https://issues.apache.org/jira/browse/KAFKA-4180 > "Shared authentification with multiple actives Kafka producers/consumers" > > which is a limitation of the current Java client that we (IBM MessageHub) > get asked quite often lately. > > We will have a go at a PR soon, just as a proof of concept, but as it > introduces new public interfaces it needs a KIP. > > I'll welcome your input. > > Edo > -------------------------------------------------- > Edoardo Comar > MQ Cloud Technologies > eco...@uk.ibm.com > +44 (0)1962 81 5576 > IBM UK Ltd, Hursley Park, SO21 2JN > > IBM United Kingdom Limited Registered in England and Wales with number > 741598 Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 > 3AU > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >
