[ 
https://issues.apache.org/jira/browse/KAFKA-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753862#comment-15753862
 ] 

ASF GitHub Bot commented on KAFKA-4540:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/2266

    KAFKA-4540: Suspended tasks that are not assigned to the StreamThread need 
to be closed before new active and standby tasks are created

    During `onPartitionsAssigned` first close, and remove, any suspended 
`StandbyTasks` that are no longer assigned to this consumer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-4540

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2266
    
----
commit 347ef4cb32c9e4ad6162160c7ba898f30941ea3c
Author: Damian Guy <damian....@gmail.com>
Date:   2016-12-15T16:15:24Z

    fix standby task suspension

commit 4f5ab9d38c3049def0ce29cd7cb191db83069a12
Author: Damian Guy <damian....@gmail.com>
Date:   2016-12-16T08:39:06Z

    merge trunk

commit 3def0307ae5185ba78b4c3ae90eafbbd50640a63
Author: Damian Guy <damian....@gmail.com>
Date:   2016-12-16T08:51:56Z

    remove metrics etc from TestStreamTask

----


> Suspended tasks that are not assigned to the StreamThread need to be closed 
> before new active and standby tasks are created
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-4540
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4540
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.2.0
>            Reporter: Damian Guy
>            Assignee: Damian Guy
>             Fix For: 0.10.2.0
>
>
> When partition assignment happens we first try and add the active tasks and 
> then add the standby tasks. The problem with this is that a new active task 
> might already be an existing suspended standby task. if this is the case then 
> when the active task initialises it will throw an exception from RocksDB:
> {{Caused by: org.rocksdb.RocksDBException: IO error: lock 
> /tmp/kafka-streams-7071/kafka-music-charts/1_1/rocksdb/all-songs/LOCK: No 
> locks available}}
> We need to make sure we have removed an closed any no-longer assigned 
> Suspended tasks before creating new tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to