[
https://issues.apache.org/jira/browse/KAFKA-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764099#comment-15764099
]
ASF GitHub Bot commented on KAFKA-4554:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/2280
KAFKA-4554: Fix `ReplicaBuffer.verifyChecksum` to use iterators instead of
iterables
This was changed in b58b6a1bef0 and caused the
`ReplicaVerificationToolTest.test_replica_lags`
system test to start failing.
I also added a unit test and a couple of other minor clean-ups.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-4554-fix-replica-buffer-verify-checksum
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2280
----
commit f85d8c46eb22b88f26b8f6219f8287c8544f9cf9
Author: Ismael Juma <[email protected]>
Date: 2016-12-20T12:26:25Z
Remove `JTestUtils.partitionRecordsBuffer` in favour of
`MemoryRecords.withRecords`
commit 185e9048d282ba6e68ba55594aa13568d0f2d035
Author: Ismael Juma <[email protected]>
Date: 2016-12-20T12:27:33Z
Fix regression in `verifyChecksum` where iterators had incorrectly been
replaced by iterables
Also add unit test.
commit 3ddfad07bbf064ff90a3856c7a8233e4e20d8222
Author: Ismael Juma <[email protected]>
Date: 2016-12-20T12:28:27Z
Use `long` instead of `Long` in `KafkaStreamsTest.onChange`
Fixes a compilation failure when compiling in IntelliJ with Java 8.
Not sure why, but `long` is better than `Long` in this case anyway.
----
> ReplicaVerificationToolTest.test_replica_lags system test failure
> -----------------------------------------------------------------
>
> Key: KAFKA-4554
> URL: https://issues.apache.org/jira/browse/KAFKA-4554
> Project: Kafka
> Issue Type: Bug
> Reporter: Roger Hoover
> Assignee: Ismael Juma
>
> {code}
> ----------------------------------------------------------------------------------------------------
> test_id:
> kafkatest.tests.tools.replica_verification_test.ReplicaVerificationToolTest.test_replica_lags
> status: FAIL
> run time: 1 minute 18.074 seconds
> Timed out waiting to reach zero replica lags.
> Traceback (most recent call last):
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.6.0-py2.7.egg/ducktape/tests/runner_client.py",
> line 123, in run
> data = self.run_test()
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.6.0-py2.7.egg/ducktape/tests/runner_client.py",
> line 176, in run_test
> return self.test_context.function(self.test)
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/tests/kafkatest/tests/tools/replica_verification_test.py",
> line 84, in test_replica_lags
> err_msg="Timed out waiting to reach zero replica lags.")
> File
> "/var/lib/jenkins/workspace/system-test-kafka/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.6.0-py2.7.egg/ducktape/utils/util.py",
> line 36, in wait_until
> raise TimeoutError(err_msg)
> TimeoutError: Timed out waiting to reach zero replica lags.
> {code}
> http://confluent-systest.s3-website-us-west-2.amazonaws.com/confluent-kafka-system-test-results/?prefix=2016-12-17--001.1481967401--apache--trunk--e156f51/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
