+1 On Tue, Jan 3, 2017 at 1:12 PM, Sriram Subramanian <r...@confluent.io> wrote:
> +1 > > On Tue, Jan 3, 2017 at 11:56 AM, Ian Wrigley <i...@confluent.io> wrote: > > > +1 from me too. When I talk to people in training classes, who are > > typically much newer to Kafka, they tend to be surprised (and > > scared/horrified) that the default is true. Much safer to set it to false > > and let people change it when they really understand the tradeoffs. > > > > Ian. > > > > --- > > Ian Wrigley > > Director, Education Services > > Confluent, Inc > > > > > On Jan 3, 2017, at 1:22 PM, Tom Crayford <tcrayf...@heroku.com> wrote: > > > > > > +1. We've been running it in production for a long time and it's the > > right > > > default. > > > > > > On Tue, Jan 3, 2017 at 7:17 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > >> Thanks for the KIP, +1 from me. > > >> > > >> Ismael > > >> > > >> On 3 Jan 2017 6:54 pm, "Ben Stopford" <b...@confluent.io> wrote: > > >> > > >>> Hi All > > >>> > > >>> Please find the below KIP which proposes changing the setting > > >>> unclean.leader.election.enabled from true to false. The motivation > for > > >>> this change is that it catches out new Kafka users who don’t realise > > the > > >>> default favours availability over data loss. > > >>> > > >>> This would mean clusters wishing to continue with unclean leader > > election > > >>> enabled would need to add the appropriate configuration on upgrade. > > >>> > > >>> Please let me know if you foresee any issue with this change, agree > or > > >>> don’t agree. > > >>> > > >>> https://cwiki.apache.org/confluence/display/KAFKA/% > > >>> 5BWIP%5D+KIP-106+-+Change+Default+unclean.leader. > > >>> election.enabled+from+True+to+False <https://cwiki.apache.org/ > > >>> confluence/display/KAFKA/[WIP]+KIP-106+-+Change+Default+ > > >>> unclean.leader.election.enabled+from+True+to+False> > > >>> > > >>> Thanks > > >>> > > >>> B > > >>> > > >>> Ben Stopford > > >>> Confluent, http://www.confluent.io <http://www.confluent.io/> > > >>> > > >>> > > >>> > > >>> > > >> > > > > >
