[ 
https://issues.apache.org/jira/browse/KAFKA-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822503#comment-15822503
 ] 

ASF GitHub Bot commented on KAFKA-4060:
---------------------------------------

GitHub user hjafarpour opened a pull request:

    https://github.com/apache/kafka/pull/2377

    Kafka 4060 docs update

    Updated the docs with changes in KAFKA-4060.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hjafarpour/kafka KAFKA-4060-docs-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2377
    
----
commit db0405c6994123417441ac328d2f9e7f96b8e851
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-20T00:10:54Z

    Removed Zookeeper dependency from Kafka Streams. Added two test for 
creating and deleting topics. They work in IDE but fail while build. Removing 
the new tests for now.

commit 69b8baf766a0ed70de8782938cf6157fa6b01794
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-20T17:52:53Z

    Made changes according to the review feedback.

commit f8952a287a7fec0d3a51db36c003a3d599491309
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-22T16:19:07Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit cb6891fe839cf6ca7ba46ca42437344764cf009e
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-22T17:13:01Z

    Made more changes based on review feedback.

commit 393b909158aadada58a796402e8b6f03c0077ef9
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-23T17:34:46Z

    Applied review feedback.

commit c19f0df4632eb2b2b9529aea0be3ed9173002b63
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-28T19:35:17Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 96264d47643b04d53293b86f3ffd718fbb688609
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-28T22:15:06Z

    Made changes based on Guozhang's comments.

commit 4f7bfd6cc4147803d90168793f498f8a1b81f18b
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-29T22:08:39Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 5e386f0fe3c109dfea95b392569adbe8f32018a0
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-30T00:22:15Z

    Disabled auto topic generation for  EmbeddedKafkaCluster. Removed polling 
in StreamPartitionAssignor.

commit eb3ec2947ad9799ed35048faafd4bf35106f880a
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-30T18:49:42Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit f44a9853cbd38f9c10a0b15bc2297d8a242fce3f
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-30T20:22:04Z

    Now deleting and re creating existing topic with different number of 
partitions.

commit 3d9dba21f0c39104f5e807a50f3fdb5956eda1bf
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-09-30T22:09:51Z

    Fixed some issues in tests.

commit 5b0be7aa1a2b1d26ae453aab78fb4989c9145411
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-07T18:41:42Z

    Sending topic management request in batch.

commit 8e064f1863aa8095cfae3f11a6f85513c498e479
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-07T21:36:12Z

    added the missing class.

commit 74ce5b9f9e4b78dee346e77ac52bc053b9cc36f6
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-07T21:45:43Z

    Merge branch 'KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new' 
of https://github.com/hjafarpour/kafka into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit c986b539ad26a2c124da60984d1cac4c2aab97dc
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-07T21:59:21Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 37079dd28a15a6d36632631227c9d718ca451745
Author: Hojjat Jafarpour <hoj...@hojjatjpoursmbp.attlocal.net>
Date:   2016-10-10T03:09:33Z

    Fixed the issue with tests.

commit 21b6907d457591ba0a242e548549d315b38e69f2
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-24T16:46:49Z

    Made minor changes based on Guozhang's feedback.

commit 3ae6583576b25f8fce4a9f4fac3f4a33bd8f47b6
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-24T16:49:23Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 253784edc252d80d5ecb3eda8ef506657f659ba1
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-24T20:35:48Z

    Minor change to ignore unnecessary error handling.

commit 3599534a55347aad55957ced02e0901082416e5f
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-10-25T22:32:44Z

    Added a retry look for internal topic creation.

commit b87334ae7626debff3cac30a9b401c52969e1e9a
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-11-08T00:16:07Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 370bcb60217d563eca3e3e6b7ed4a701aacd6ca3
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-11-28T22:46:38Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 6ef4cd1a01af6af21081acb03775566305a974a5
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2016-11-29T00:28:39Z

    Refactored the StreamsKafkaClient based on the changes in the client 
protocol.

commit ff542e60381dc3402b90f3b2e4d00e935179d2a4
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2017-01-04T23:27:10Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit 3063b20f72e62ffb4ba4833f5c08a8dcf6df849a
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2017-01-07T00:47:49Z

    Made changes based on feedbacks.

commit 3e1ec0213d4b1f8688bb081b70dcf194f92fea88
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2017-01-10T22:09:07Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit f597e2fa3120640ebc31bea1b87f8802df04aa81
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2017-01-13T22:12:17Z

    Merge branch 'trunk' into 
KAFKA-4060-Remove-ZkClient-dependency-in-Kafka-Streams-new

commit a67a57de2d3813d443131cf00040e12f6f2dd3c7
Author: Hojjat Jafarpour <hojjat@hojjat-jafarpours-mbp.local>
Date:   2017-01-13T23:05:47Z

    Updated the docs. KAFKA-4060 changes were added to the upgrade notes.

----


> Remove ZkClient dependency in Kafka Streams
> -------------------------------------------
>
>                 Key: KAFKA-4060
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4060
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Hojjat Jafarpour
>              Labels: kip
>             Fix For: 0.10.2.0
>
>
> In Kafka Streams we need to dynamically create or update those internal 
> topics (i.e. repartition topics) upon rebalance, inside 
> {{InternalTopicManager}} which is triggered by {{StreamPartitionAssignor}}. 
> Currently we are using {{ZkClient}} to talk to ZK directly for such actions.
> With create and delete topics request merged in by [~granthenke] as part of 
> KIP-4, we should now be able to remove the ZkClient dependency and directly 
> use these requests.
> Related: 
> 1. KIP-4. 
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations
> 2. Consumer Reblance Protocol. 
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Client-side+Assignment+Proposal



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to