[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823190#comment-15823190
]
ASF GitHub Bot commented on KAFKA-4617:
---------------------------------------
GitHub user dhwanikatagade opened a pull request:
https://github.com/apache/kafka/pull/2382
KAFKA-4617: Generate core project with correct source folders.
Generate core project with correct source folders. In addition set output
folders same as command line build. Don't generate unnecessary projects
(https://issues.apache.org/jira/browse/KAFKA-4604)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhwanikatagade/kafka
gradle_eclipse_plugin_path_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2382
----
commit abe4eadc4a8352cfab1f0125700a29415fd270bf
Author: Dhwani Katagade <dhwani_katag...@persistent.com>
Date: 2017-01-07T15:26:17Z
KAFKA-4617: Generate core project with correct source folders. In addition
set output folders same as command line build. Don't generate unnecessary
projects.
----
> gradle-generated core eclipse project has incorrect source folder structure
> ---------------------------------------------------------------------------
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
> Reporter: Edoardo Comar
> Assignee: Dhwani Katagade
> Priority: Minor
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
> <classpathentry kind="src" path="src/main/scala"/>
> <classpathentry kind="src" path="src/test/scala"/>
> <classpathentry kind="src" path="src/test/resources"/>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
> <classpathentry kind="src" path="src/main/scala"/>
> <classpathentry excluding="integration/|other/|unit/" kind="src"
> path="src/test/scala"/>
> <classpathentry kind="src" path="src/test/scala/other"/>
> <classpathentry kind="src" path="src/test/scala/integration"/>
> <classpathentry kind="src" path="src/test/scala/unit"/>
> <classpathentry kind="src" path="src/test/resources"/>
> {code}
> Moreover, the classpath included as libraries core/build/test and
> core/build/resources
> which should not be there as the eclipse classes are not generated under build
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
