[
https://issues.apache.org/jira/browse/KAFKA-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839447#comment-15839447
]
ASF GitHub Bot commented on KAFKA-4699:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/2440
KAFKA-4699: Invoke producer callbacks before completing the future
This behaviour was changed in 8b3c6c0, but it caused interceptor
test failures (which rely on callbacks) and since we’re so close to
code freeze, it’s better to be conservative.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-4699-callbacks-invoked-before-future-is-completed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2440
----
commit a24f8ac1b61d5371a33c1780e582f7fdd6a7aaf7
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-01-26T09:15:33Z
KAFKA-4699: Invoke producer callbacks before completing the future
This behaviour was changed in 8b3c6c0a1, but it caused interceptor
test failures (which rely on callbacks) and since we’re so close to
code freeze, it’s better to be conservative.
commit 760c06c0f163b0855ae6e321ab36b78589ff2aa0
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-01-26T09:15:56Z
Minor clean-ups in `testInterceptors`
commit 893e6fe26c0f31ab5b73746e1e4e29430e6f02f6
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-01-26T09:16:19Z
Fix a compiler failure in IntelliJ with Java 8 in
SourceTaskOffsetCommitterTest
----
> Transient Failure PlaintextConsumerTest.testInterceptros
> --------------------------------------------------------
>
> Key: KAFKA-4699
> URL: https://issues.apache.org/jira/browse/KAFKA-4699
> Project: Kafka
> Issue Type: Bug
> Components: unit tests
> Reporter: Jason Gustafson
> Assignee: Ismael Juma
> Fix For: 0.10.2.0
>
>
> Started seeing a bunch of these. Possibly related to KAFKA-4633?
> {code}
> kafka.api.PlaintextConsumerTest > testInterceptors FAILED
> java.lang.AssertionError: expected:<10> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> kafka.api.PlaintextConsumerTest.testInterceptors(PlaintextConsumerTest.scala:858)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
