GitHub user rnpridgeon opened a pull request:
https://github.com/apache/kafka/pull/2533
Checking the Timestamp is insufficient
My understanding is that the record format allots 1 bit for the timestamp
type field. As a result it can be either 1 or 0 and never -1. This means
Connect's timestamp type validation is insufficient. Instead the records
timestamp value itself should be checked.
Technically the timestamp value should never be another negative value but
while we are being defensive we may as well go all the way.
Doing so inside Connect takes the burden off Connector developers which I
think is a good thing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rnpridgeon/kafka no_timestamp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2533.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2533
----
commit cd4d8130ce2fa3a5f864bf65c7b610aaf72d4d0d
Author: rnpridgeon <[email protected]>
Date: 2017-02-10T11:17:38Z
Checking the Timestamp is insufficient
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
