[ 
https://issues.apache.org/jira/browse/KAFKA-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872284#comment-15872284
 ] 

Onur Karaman commented on KAFKA-4757:
-------------------------------------

[~cmccabe] I double checked and the 2nd logging issue still appears after 
KAFKA-4635. My trunk is currently at git hash 
2c91b324d4798138dd479f54269bdc4f39339817.

My initial guess is that it's related to ApiVersionsRequest, as the line 
following the bad log line usually contains a completed receive of api_key=18:
{code}
[2017-02-17 10:38:40,312] TRACE Sending {} to node 1. 
(org.apache.kafka.clients.NetworkClient)
[2017-02-17 10:38:40,312] TRACE Completed receive from node 1, for key 18, 
received 
{error_code=0,api_versions=[{api_key=0,min_version=0,max_version=2},{api_key=1,min_version=0,max_version=3},{api_key=2,min_version=0,max_version=1},{api_key=3,min_version=0,max_version=2},{api_key=4,min_version=0,max_version=0},{api_key=5,min_version=0,max_version=0},{api_key=6,min_version=0,max_version=3},{api_key=7,min_version=1,max_version=1},{api_key=8,min_version=0,max_version=2},{api_key=9,min_version=0,max_version=2},{api_key=10,min_version=0,max_version=0},{api_key=11,min_version=0,max_version=1},{api_key=12,min_version=0,max_version=0},{api_key=13,min_version=0,max_version=0},{api_key=14,min_version=0,max_version=0},{api_key=15,min_version=0,max_version=0},{api_key=16,min_version=0,max_version=0},{api_key=17,min_version=0,max_version=0},{api_key=18,min_version=0,max_version=0},{api_key=19,min_version=0,max_version=1},{api_key=20,min_version=0,max_version=0}]}
 (org.apache.kafka.clients.NetworkClient)
{code}

> NetworkClient should log request details at trace level when a request is 
> cancelled because of disconnection
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-4757
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4757
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Onur Karaman
>            Assignee: Colin P. McCabe
>
> Two issues here:
> 1. Here's what NetworkClient now shows when processing a disconnection:
> {code}
> [2017-02-10 10:48:57,052] TRACE Cancelled request 
> org.apache.kafka.clients.NetworkClient$InFlightRequest@52f759d7 due to node 0 
> being disconnected (org.apache.kafka.clients.NetworkClient)
> {code}
> The log at one point was useful and actually showed the contents of the 
> request. For instance, with FetchRequest, you used to be able to see which 
> partitions were requested as well as the offsets and max bytes requested per 
> partition.
> It looks like InFlightRequest itself doesn't actually hold the request but 
> instead currently just holds the RequestHeader. We probably want to make 
> InFlightRequest hold the entire request to make the original request show up 
> in the logs.
> 2. Sometimes I see the following log:
> {code}
> [2017-02-10 10:53:59,015] TRACE Sending {} to node 0. 
> (org.apache.kafka.clients.NetworkClient)
> {code}
> Again not very insightful.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to