GitHub user original-brownbear opened a pull request:
https://github.com/apache/kafka/pull/2582
MINOR: Fixed Non-Final Close Method + its Duplication
Trivial but in my opinion it's well worth it making the `close` method
`final` here and also deleting that duplication (especially since it's hiding
the fact that the `close` is synchronized here).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/original-brownbear/kafka
cleanup-nonfinal-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2582.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2582
----
commit 49e2e3a2ff8940f2ac8489ed39492085ab063d82
Author: Armin Braun <m...@obrown.io>
Date: 2017-02-22T05:49:52Z
MINOR: Fixed nonfinal closed method + duplication
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
