[ 
https://issues.apache.org/jira/browse/KAFKA-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880385#comment-15880385
 ] 

Manikumar commented on KAFKA-4788:
----------------------------------

[~ijuma]  While using kafka-topics.sh, we are doing topic-level config 
validation on the client (TopicCommand) side, not at broker side. So we don't 
have access to broker configs and KAFKA-4092 validation does not work. This 
validation can be added to Create Topic/Admin Request request code path.

Also, KAFKA-4092 change may not be required. it's just config error, not a bug. 
We don't have this check for default broker configs (without topic-level 
configs). Maybe we can revert the patch. 

> Broker level configuration 'log.segment.bytes' not used when 'segment.bytes' 
> not configured per topic.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-4788
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4788
>             Project: Kafka
>          Issue Type: Bug
>          Components: log
>    Affects Versions: 0.10.2.0
>            Reporter: Ciprian Pascu
>              Labels: regression
>             Fix For: 0.10.3.0, 0.10.2.1
>
>
> In the previous version, if there was not topic level configuration 
> 'segment.bytes', then the corresponding value from the broker configuration 
> was used (for 'segment.bytes', this is the value configured for 
> 'log.segment.bytes'); in 0.10.2.0, if the configuration at topic level is 
> missing, then the value configured at broker level is not used, some kind of 
> default value for that broker level configuration is used (for 
> 'log.retention.bytes', this is 'val LogSegmentBytes = 1 * 1024 * 1024 * 
> 1024').
> However, in the documentation it is said: 'A given server default config 
> value only applies to a topic if it does not have an explicit topic config 
> override.'; so, according to this, if there is, for example, no value 
> configured for 'segment.bytes', then the value configured for 
> 'log.segment.bytes' should be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to