[ 
https://issues.apache.org/jira/browse/KAFKA-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884872#comment-15884872
 ] 

ASF GitHub Bot commented on KAFKA-4806:
---------------------------------------

GitHub user Gacko opened a pull request:

    https://github.com/apache/kafka/pull/2600

    KAFKA-4806: Prevent double logging of ConsumerConfig.

    The consumer properties get logged twice since two instances of 
ConsumerConfig are created during creation of KafkaConsumer.
    
    I added a constructor of ConsumerConfig accepting the boolean parameter 
doLog which is already passable in AbstractConfig and set it to false during 
the second ConsumerConfig creating in the KafkaConsumer constructor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Gacko/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2600
    
----
commit e51683bd171bbd6288f21615e3c1fba3f1c9e454
Author: Marco Ebert <marco_eb...@icloud.com>
Date:   2017-02-26T19:10:37Z

    KAFKA-4806: Prevent double logging of ConsumerConfig by adding constructor 
with doLog parameter.

----


> KafkaConsumer: ConsumerConfig gets logged twice.
> ------------------------------------------------
>
>                 Key: KAFKA-4806
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4806
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.0.1
>            Reporter: Marco Ebert
>            Priority: Minor
>
> The ConsumerConfig created from given Properties during KafkaConsumer 
> construction gets logged twice since the ConsumerConfig constructor does so.
> https://github.com/apache/kafka/blob/0.10.0.1/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L587
> https://github.com/apache/kafka/blob/0.10.0.1/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L643



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to