GitHub user nnordrum opened a pull request:

    https://github.com/apache/kafka/pull/2664

    MINOR: Added additional -start/-stop files for consistency

    I added *-start.sh and *-stop.sh for connect-* and kafka-mirror-maker to 
follow the pattern used by the other services. The purpose of this is to make 
all services follow the pattern of ${COMPONENT_NAME}-start.sh and 
${COMPONENT_NAME}-stop.sh.
    
    I did a copy of the files into the -start.sh files instead of making one 
use the other because I was trying to be the most patch-friendly for who know 
what people did in their forks, but the idea would be to logically deprecate 
the non -start.sh files that should go away, update the documentation, etc., 
and eventually (with any luck) delete the originals on the next major version 
bump.
    
    The contribution is my original work and that I license the work to the 
project under the project's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nnordrum/kafka removing_sh_inconsistencies

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2664
    
----
commit 5d9110cbd8343a187599c979283ecd027e7b3f64
Author: Noah Nordrum <noah.nord...@optum.com>
Date:   2017-03-09T20:14:31Z

    added *-start.sh and *-stop.sh for connect-* and kafka-mirror-maker to 
follow the pattern used by the other services.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to