[
https://issues.apache.org/jira/browse/KAFKA-4899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925336#comment-15925336
]
Colin P. McCabe commented on KAFKA-4899:
----------------------------------------
* {{gradle/findbugs-exclude.xml}}: supress some checks which don't work well on
Scala code. Be more detailed about what checks are suppressed for Java code.
* {{MirrorMaker.scala}}: fix a case where we could get a spurious wakeup and
exit prematurely from {{requestAndWaitForCommit}}
* {{ImportZkOffsets.scala}}, {{BrokerMetadataCheckpoint.scala}}: fix a file
descriptor leak
* {{Log.scala}}, {{BrokerMetadataCheckpoint.scala}}, {{FileLock.scala}},
{{OffsetCheckpoint.java}}, {{KafkaCSVMetricsReporter.scala}},
{{LogManager.scala}}, {{LogSegment.scala}}: fix cases where an I/O operation
could fail silently
* {{MirrorMaker.scala}}: fix cases where we were using {{instanceof}} but did
not need to be.
* {{KafkaApis.scala}}: remove unused import
* {{AdminUtils.scala}}: fix a case where explicitly calling toString() was not
necessary, since it would be called implicitly
* {{ConsumerFetcherThread.scala}}: fix a case where we could use the default
case statement instead of having a separate case statement.
* {{TopicCount.scala}}: implement {{hashCode}}, since {{equals}} is implemented.
* {{FetchRequest.scala}}, {{FetchResponse.scala}},
{{TopicMetadataRequest.scala}}, {{OffsetResponse.scala}},
{{OffsetRequest.scala}}, {{OffsetFetchRequest. scala}},
{{OffsetCommitRequest.scala}}, {{GroupCoordinatorResponse.scala}}: refactor
{{equals}} to be more straightforward (and avoid an FB warning)
* {{ClientQuotaManager.scala}}: make the class final to avoid a warning about
calling {{Thread#start}} in the constructor.
* {{LogCleaner.scala}}, {{LogCleanerManager.scala}}: suppress warning about
unchcked result of {{await}}
* {{KafkaMetricsReporter.scala}}: simplify synchronization since AtomicBoolean
is not needed.
> Fix findbugs warnings in kafka-core
> -----------------------------------
>
> Key: KAFKA-4899
> URL: https://issues.apache.org/jira/browse/KAFKA-4899
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
>
> Fix findbugs warnings in kafka-core
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
