[
https://issues.apache.org/jira/browse/KAFKA-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938458#comment-15938458
]
Sönke Liebau commented on KAFKA-4930:
-------------------------------------
After a good nights sleep I am beginning to think that between this and
[KAFKA-4938|https://issues.apache.org/jira/browse/KAFKA-4938] a better approach
might be to change the _nonEmpty_ Validator to a more specialised _ValidName_
validator, which could check for empty strings, backslashes and other
problematic characters (I think there are a few more jiras around).
The problematic check in
[KAFKA-4938|https://issues.apache.org/jira/browse/KAFKA-4938] could be replaced
by a check for null, if no name parameter is present in the request at all,
which we could consider a bad request I think, so the BadRequest Exception
makes sense here.
> Connect Rest API allows creating connectors with an empty name
> --------------------------------------------------------------
>
> Key: KAFKA-4930
> URL: https://issues.apache.org/jira/browse/KAFKA-4930
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 0.10.2.0
> Reporter: Sönke Liebau
> Priority: Minor
>
> The Connect Rest API allows to deploy connectors with an empty name field,
> which then cannot be removed through the api.
> Sending the following request:
> {code}
> {
> "name": "",
> "config": {
> "connector.class":
> "org.apache.kafka.connect.tools.MockSourceConnector",
> "tasks.max": "1",
> "topics": "test-topic"
>
> }
> }
> {code}
> Results in a connector being deployed which can be seen in the list of
> connectors:
> {code}
> [
> "",
> "testconnector"
> ]{code}
> But cannot be removed via a DELETE call, as the api thinks we are trying to
> delete the /connectors endpoint and declines the request.
> I don't think there is a valid case for the connector name to be empty so
> perhaps we should add a check for this. I am happy to work on this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
