Hi Jorge, Thanks for the detailed KIP. The tool looks very useful. A few comments:
1. We are using the default timezone of the client for the specified date. This seems a bit error prone. Would it be better to require the users to specify the time zone as part of the date time? We should at least allow it, but my experience when it comes to using the default time zone in a distributed environment is not great. 2. It seems like we are using the ISO 8601 format for date time and duration. It would be good to mention that. 3. `shift-by` should perhaps be `shift-offset-by` to be a bit clearer. 4. Printing the current offset via reset-offsets is a bit odd, can we not use a different option for that? 5. It's a bit odd that `by-duration` subtracts while `shift-by` moves forward. It would be nice if the name made it clear that `by-duration` is subtracting, but I have no good suggestions, so maybe that's the best we can do. Ismael On Fri, Feb 24, 2017 at 12:46 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi All, > > It seems that there is no further concern with the KIP-122. > At this point we would like to start the voting process. > > The KIP can be found here: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 122%3A+Add+Reset+Consumer+Group+Offsets+tooling > > > Thanks! > > Jorge. >
