Jun Rao created KAFKA-5036: ------------------------------ Summary: Followups from KIP-101 Key: KAFKA-5036 URL: https://issues.apache.org/jira/browse/KAFKA-5036 Project: Kafka Issue Type: Improvement Affects Versions: 0.11.0.0 Reporter: Jun Rao Assignee: Jun Rao
1. It would be safer to hold onto the leader lock in Partition while serving an OffsetForLeaderEpoch request. 2. Currently, we update the leader epoch in epochCache after log append in the follower but before log append in the leader. It would be more consistent to always do this after log append. This also avoids issues related to failure in log append. 3. OffsetsForLeaderEpochRequest/OffsetsForLeaderEpochResponse: The code that does grouping can probably be replaced by calling CollectionUtils.groupDataByTopic(). -- This message was sent by Atlassian JIRA (v6.3.15#6346)