[
https://issues.apache.org/jira/browse/KAFKA-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961532#comment-15961532
]
ASF GitHub Bot commented on KAFKA-5042:
---------------------------------------
GitHub user twbecker opened a pull request:
https://github.com/apache/kafka/pull/2826
Fix KAFKA-5042.
InFlightRequests#canSendMore should not require that previous sends
completed if we are under the maxInFlightRequestsPerConnection limit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twbecker/kafka KAFKA-5042
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2826.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2826
----
commit 7769b58e12be2f5ff0d9af44126b761620399ecb
Author: Tommy Becker <twbec...@gmail.com>
Date: 2017-04-07T22:27:40Z
Fix KAFKA-5042.
InFlightRequests#canSendMore should not require that previous sends
completed if we are under the maxInFlightRequestsPerConnection limit.
----
> InFlightRequests#isEmpty() always returns false
> -----------------------------------------------
>
> Key: KAFKA-5042
> URL: https://issues.apache.org/jira/browse/KAFKA-5042
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: Tommy Becker
> Assignee: Ismael Juma
> Fix For: 0.11.0.0
>
>
> While perusing the NetworkClient code I came across the following:
> InFlightRequests#isEmpty() always returns false.
> {code}
> public boolean isEmpty() {
> for (Deque<NetworkClient.InFlightRequest> deque :
> this.requests.values()) {
> if (!deque.isEmpty())
> return false;
> }
> return false;
> }
> {code}
> This method looks like a recent addtion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
