[
https://issues.apache.org/jira/browse/KAFKA-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979768#comment-15979768
]
ASF GitHub Bot commented on KAFKA-5111:
---------------------------------------
GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/2895
KAFKA-5111: Improve internal Task APIs
Refactors Task with proper interface methods `init()`, `resume()`,
`commit()`, `suspend()`, and `close()`. All other methods for task handling are
internal now. This allows to simplify `StreamThread` code, avoid code
duplication and allows for easier reasoning of control flow.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka kafka-5111-cleanup-task-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2895.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2895
----
commit d2a4593e967ca4804291c50baece5c66f3469f59
Author: Matthias J. Sax <[email protected]>
Date: 2017-04-21T23:24:05Z
Code Cleanup
commit 27a4d7da6716bff235557ae0ada89abddfdc0f39
Author: Matthias J. Sax <[email protected]>
Date: 2017-04-22T02:05:45Z
KAFKA-5111: Improve internal Task APIs
commit 45bbc1714cccc98814b49b2dd30638e10f4eb317
Author: Matthias J. Sax <[email protected]>
Date: 2017-04-22T04:57:08Z
Post code cleanup
----
> Improve internal Task APIs
> --------------------------
>
> Key: KAFKA-5111
> URL: https://issues.apache.org/jira/browse/KAFKA-5111
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Fix For: 0.11.0.0
>
>
> Currently, the internal interface for tasks is not very clean and it's hard
> to reason about the control flow when tasks get closes, suspended, resumed
> etc. This makes exception handling particularly hard.
> We want to refactor this part of the code to get a clean control flow and
> interface.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
