Having "MarkedForDeletion" before "Configs" may break anyone who is parsing this output, since they may be expecting the 4th string to be "Configs".
I know that the Compatibility section already says that people parsing this may have to adjust their parsing logic, so maybe that covers my concern already. But inserting the new MarkedForDeletion word into the middle of the string seems like it'll break parsing more than just adding a new value at the end. I'm fine either way, though. -James > On Apr 25, 2017, at 9:38 AM, Vahid S Hashemian <vahidhashem...@us.ibm.com> > wrote: > > Thanks for the KIP Mickael. > Looks good. I also prefer 'MarkedForDeletion' before 'Configs'. > > --Vahid > > > > From: Ismael Juma <ism...@juma.me.uk> > To: dev@kafka.apache.org > Date: 04/25/2017 04:15 AM > Subject: Re: [DISCUSS] KIP-137: Enhance TopicCommand --describe to > show topics marked for deletion > Sent by: isma...@gmail.com > > > > Thanks for the KIP. Would it make sense for MarkedForDeletion to be before > `Configs`? I can see arguments both ways, so I was wondering what your > thoughts were? > > Ismael > > On Thu, Mar 30, 2017 at 5:39 PM, Mickael Maison <mickael.mai...@gmail.com> > wrote: > >> Hi all, >> >> We created KIP-137: Enhance TopicCommand --describe to show topics >> marked for deletion >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> > 137%3A+Enhance+TopicCommand+--describe+to+show+topics+marked+for+deletion >> >> Please help review the KIP. You feedback is appreciated! >> >> Thanks >> > > > >
