[ https://issues.apache.org/jira/browse/KAFKA-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984837#comment-15984837 ]
ASF GitHub Bot commented on KAFKA-5127: --------------------------------------- GitHub user baluchicken opened a pull request: https://github.com/apache/kafka/pull/2919 KAFKA-5127 Replace pattern matching with foreach where the case None … @ijuma plz review. This one is not complete because KafkaController, AdminUtils and ReplicaStateMachine has some of these but for those I will wait until the KAFKA-5028 and KAFKA-5103 are merged. You can merge this pull request into a Git repository by running: $ git pull https://github.com/baluchicken/kafka-1 KAFKA-5127 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2919.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2919 ---- commit 553ef1acd456799f9aa4871c0a1a764eb88fad51 Author: Balint Molnar <balintmolna...@gmail.com> Date: 2017-04-26T13:44:11Z KAFKA-5127 Replace pattern matching with foreach where the case None is unused ---- > Replace pattern matching with foreach where the case None is unused > -------------------------------------------------------------------- > > Key: KAFKA-5127 > URL: https://issues.apache.org/jira/browse/KAFKA-5127 > Project: Kafka > Issue Type: Bug > Components: core > Reporter: Balint Molnar > Assignee: Balint Molnar > Priority: Minor > > There are various place where pattern matching is used with matching only for > one thing and ignoring the None type, this can be replaced with foreach. -- This message was sent by Atlassian JIRA (v6.3.15#6346)