[
https://issues.apache.org/jira/browse/KAFKA-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987184#comment-15987184
]
ASF GitHub Bot commented on KAFKA-5107:
---------------------------------------
GitHub user onurkaraman opened a pull request:
https://github.com/apache/kafka/pull/2927
KAFKA-5107: remove preferred replica election state from ControllerContext
KAFKA-5028 moves the controller to a single-threaded model, so we would no
longer have work interleaved between preferred replica leader election, meaning
we don't need to keep its state.
This patch additionally addresses a bug from KAFKA-5028 where it made
onPreferredReplicaElection keep the line calling
topicDeletionManager.markTopicIneligibleForDeletion but removes the line
calling topicDeletionManager.resumeDeletionForTopics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/onurkaraman/kafka KAFKA-5107
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2927.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2927
----
commit 906f05c6ab9e8f7806cdfb3418b1dabfe0a4f5f1
Author: Onur Karaman <[email protected]>
Date: 2017-04-27T17:44:02Z
KAFKA-5107: remove preferred replica election state from ControllerContext
KAFKA-5028 moves the controller to a single-threaded model, so we would no
longer have work interleaved between preferred replica leader election, meaning
we don't need to keep its state.
This patch additionally addresses a bug from KAFKA-5028 where it made
onPreferredReplicaElection keep the line calling
topicDeletionManager.markTopicIneligibleForDeletion but removes the line
calling topicDeletionManager.resumeDeletionForTopics
----
> remove preferred replica election state from ControllerContext
> --------------------------------------------------------------
>
> Key: KAFKA-5107
> URL: https://issues.apache.org/jira/browse/KAFKA-5107
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Onur Karaman
> Assignee: Onur Karaman
>
> KAFKA-5028 moves the controller to a single-threaded model, so we would no
> longer have work interleaved between preferred replica leader election,
> meaning we don't need to keep its state.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
