[
https://issues.apache.org/jira/browse/KAFKA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988230#comment-15988230
]
ASF GitHub Bot commented on KAFKA-5137:
---------------------------------------
GitHub user umesh9794 opened a pull request:
https://github.com/apache/kafka/pull/2932
KAFKA-5137 : Controlled shutdown timeout message improvement
This PR improves the warning message by adding correct config details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/umesh9794/kafka local
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2932.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2932
----
commit f2b35a8e56d83301a42a09fef61a9ba752acce70
Author: umesh9794 <[email protected]>
Date: 2017-04-28T05:14:04Z
KAFKA-5137 : Controlled shutdown timeout message improvement
----
> Controlled shutdown timeout message improvement
> -----------------------------------------------
>
> Key: KAFKA-5137
> URL: https://issues.apache.org/jira/browse/KAFKA-5137
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.10.2.0
> Reporter: Dustin Cote
> Priority: Minor
> Labels: newbie
>
> Currently if you fail during controlled shutdown, you can get a message that
> says the socket.timeout.ms has expired. This config actually doesn't exist on
> the broker. Instead, we should explicitly say if we've hit the
> controller.socket.timeout.ms or the request.timeout.ms as it's confusing to
> take action given the current message. I believe the relevant code is here:
> https://github.com/apache/kafka/blob/0.10.2/core/src/main/scala/kafka/server/KafkaServer.scala#L428-L454
> I'm also not sure if there's another timeout that could be hit here or
> another reason why IOException might be thrown. In the least we should call
> out those two configs instead of the non-existent one but if we can direct to
> the proper one that would be even better.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
