Probably should remove the words in the kip the other constructors are going to be deprecated if they aren't any more with just the tactical change
Sent using OWA for iPhone ________________________________________ From: Michael Pearce <michael.pea...@ig.com> Sent: Saturday, April 29, 2017 6:04:00 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface +1 N.b. it is a shame we don't work on the contention to work a better way forwards. ________________________________________ From: Stephane Maarek <steph...@simplemachines.com.au> Sent: Saturday, April 29, 2017 4:39:32 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface Hi Thanks for all your input. My initial intent was to just add a “timestamp” constructor for the ProducerRecord, and it seems greater changes are too contentious. I’ve just rolled back the PR to add the missing constructors, in the way Ismael suggested. Updated KIP here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=69406838 Added constructors here: https://github.com/apache/kafka/pull/2894 Let me know your thoughts, Regards, Stephane On 25/4/17, 2:58 am, "Michael Pearce" <michael.pea...@ig.com> wrote: Why not simply make a cleaner client fluent API wrapper? The internals use and send via current api, but provide a cleaner more fluent api. A good example here is HTTP compontents where they did this. https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fluent.html On 24/04/2017, 17:40, "Matthias J. Sax" <matth...@confluent.io> wrote: Hey Jay, I understand your concern, and for sure, we will need to keep the current constructors deprecated for a long time (ie, many years). But if we don't make the move, we will not be able to improve. And I think warnings about using deprecated APIs is an acceptable price to pay. And the API improvements will help new people who adopt Kafka to get started more easily. Otherwise Kafka might end up as many other enterprise software with a lots of old stuff that is kept forever because nobody has the guts to improve/change it. Of course, we can still improve the docs of the deprecated constructors, too. Just my two cents. -Matthias On 4/23/17 3:37 PM, Jay Kreps wrote: > Hey guys, > > I definitely think that the constructors could have been better designed, > but I think given that they're in heavy use I don't think this proposal > will improve things. Deprecating constructors just leaves everyone with > lots of warnings and crossed out things. We can't actually delete the > methods because lots of code needs to be usable across multiple Kafka > versions, right? So we aren't picking between the original approach (worse) > and the new approach (better); what we are proposing is a perpetual > mingling of the original style and the new style with a bunch of deprecated > stuff, which I think is worst of all. > > I'd vote for just documenting the meaning of null in the ProducerRecord > constructor. > > -Jay > > On Wed, Apr 19, 2017 at 3:34 PM, Stephane Maarek < > steph...@simplemachines.com.au> wrote: > >> Hi all, >> >> My first KIP, let me know your thoughts! >> https://cwiki.apache.org/confluence/display/KAFKA/KIP+ >> 141+-+ProducerRecordBuilder+Interface >> >> >> Cheers, >> Stephane >> > The information contained in this email is strictly confidential and for the use of the addressee only, unless otherwise indicated. If you are not the intended recipient, please do not read, copy, use or disclose to others this message or any attachment. Please also notify the sender by replying to this email or by telephone (+44(020 7896 0011) and then delete the email and any copies of it. Opinions, conclusion (etc) that do not relate to the official business of this company shall be understood as neither given nor endorsed by it. IG is a trading name of IG Markets Limited (a company registered in England and Wales, company number 04008957) and IG Index Limited (a company registered in England and Wales, company number 01190902). Registered address at Cannon Bridge House, 25 Dowgate Hill, London EC4R 2YA. Both IG Markets Limited (register number 195355) and IG Index Limited (register number 114059) are authorised and regulated by the Financial Conduct Authority.
