[
https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990333#comment-15990333
]
ASF GitHub Bot commented on KAFKA-5144:
---------------------------------------
GitHub user mihbor opened a pull request:
https://github.com/apache/kafka/pull/2948
KAFKA-5144 renamed and added comments to make it clear what's going on
The descendingSubsequence is a misnomer. The linked list is actually
arranged so that the lowest timestamp is first and larger timestamps are added
to the end, therefore renamed to ascendingSubsequence.
The minElem variable was also misnamed. It's actually the current maximum
element as it's taken from the end of the list.
Added comment to get() to make it clear it's returning the lowest timestamp.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mihbor/kafka patch-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2948.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2948
----
commit c8d5f4646e412917495f720102774e450ae06265
Author: mihbor <mih...@users.noreply.github.com>
Date: 2017-04-30T18:36:08Z
KAFKA-5144 rename variables and add comments to make it clear what's going
on
The descendingSubsequence is a misnomer. The linked list is actually
arranged so that the lowest timestamp is first and larger timestamps are added
to the end, therefore renamed to ascendingSubsequence.
The minElem variable was also misnamed. It's actually the current maximum
element as it's taken from the end of the list.
Added comment to get() to make it clear it's returning the lowest timestamp.
----
> MinTimestampTracker does not correctly add timestamps lower than the current
> max
> --------------------------------------------------------------------------------
>
> Key: KAFKA-5144
> URL: https://issues.apache.org/jira/browse/KAFKA-5144
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.2.1
> Reporter: Michal Borowiecki
> Assignee: Michal Borowiecki
>
> When adding elements MinTimestampTracker removes all existing elements
> greater than the added element.
> Perhaps I've missed something and this is intended behaviour but I can't find
> any evidence for that in comments or tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
