Hi Jun, Thanks for the review.
1. Yes, a Set would work too. I updated to take Collection for consistency as Colin said. 2. That was a typo, it should have been a boolean indicating whether we should only perform validation. Updated the KIP. Thanks, Ismael On Fri, May 5, 2017 at 6:35 PM, Jun Rao <j...@confluent.io> wrote: > Hi, Ismael, > > Thanks for the KIP. Looks good overall. Just a couple of minor comments. > > 1. Should AdminClient.listConfigs() take a set of ConfigEntity instead of a > list? > > 2. validateOnly(boolean timeout): Should the time be Integer? > > Jun > > > On Thu, May 4, 2017 at 7:32 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > > Hi all, > > > > We've posted "KIP-133: List and Alter Configs Admin APIs" for discussion: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 133%3A+List+and+Alter+Configs+Admin+APIs > > > > This completes the first batch of AdminClient APIs so that topic, config > > and ACL management is supported. > > > > Please take a look. Your feedback is appreciated. > > > > Thanks, > > Ismael > > >
