GitHub user mimaison opened a pull request:

    https://github.com/apache/kafka/pull/3003

    KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec me…

    …tric
    
    Also added 2 new metrics to account for incoming/outgoing traffic due to 
internal replication
    - ReplicationBytesInPerSec
    - ReplicationBytesOutPerSec
    
    We had a look at creating an integration test to verify the 
Bytes/Replication In/Out metrics but had issues.
    When running using IntegrationTestHarness, all the brokers were using the 
same Yammer Metrics registry and metrics name collided. 
    
    Also although we only update the global value for the 2 new metrics, we can 
see an inner node for each topic (that stays 0).
    eg: 
kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesOutPerSec,topic=testtopic
    
     It looks like something forced by BrokerTopicMetrics. If there's no way to 
remove them, then we might want to update them accordingly to give them 
meaningful values

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka KAFKA-5194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3003
    
----
commit ce34c59e80d3ecd6d0473b2867b839da5edd1bb6
Author: Mickael Maison <mickael.mai...@gmail.com>
Date:   2017-05-08T16:44:51Z

    KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec metric
    
    Also added 2 new metrics to account for incoming/outgoing traffic due to 
internal replication
    - ReplicationBytesInPerSec
    - ReplicationBytesOutPerSec

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to