[
https://issues.apache.org/jira/browse/KAFKA-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003338#comment-16003338
]
ASF GitHub Bot commented on KAFKA-4982:
---------------------------------------
GitHub user edoardocomar opened a pull request:
https://github.com/apache/kafka/pull/3004
KAFKA-4982: add protocol and listener tags to socket-server-metrics
Added tags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edoardocomar/kafka KAFKA-4982
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3004
----
commit 969f01ecf973cc6ccbb45ea2b46f8681049b4af8
Author: Edoardo Comar <eco...@uk.ibm.com>
Date: 2017-04-10T12:29:42Z
KAFKA-4982: add protocol and listener tags to socket-server-metrics
----
> Add listener tag to socket-server-metrics.connection-... metrics
> ------------------------------------------------------------------
>
> Key: KAFKA-4982
> URL: https://issues.apache.org/jira/browse/KAFKA-4982
> Project: Kafka
> Issue Type: Improvement
> Reporter: Edoardo Comar
> Assignee: Edoardo Comar
> Fix For: 0.11.0.0
>
>
> Metrics in socket-server-metrics like connection-count connection-close-rate
> etc are tagged with networkProcessor:<id>
> where the id of a network processor is just a numeric integer.
> If you have more than one listener (eg PLAINTEXT, SASL_SSL, etc.), the id
> just keeps incrementing and when looking at the metrics it is hard to match
> the metric tag to a listener.
> You need to know the number of network threads and the order in which the
> listeners are declared in the brokers' server.properties.
> We should add a tag showing the listener label, that would also make it much
> easier to group the metrics in a tool like grafana
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
