[
https://issues.apache.org/jira/browse/KAFKA-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017489#comment-16017489
]
ASF GitHub Bot commented on KAFKA-5266:
---------------------------------------
GitHub user jeqo opened a pull request:
https://github.com/apache/kafka/pull/3102
Implement Improvements
Implement improvements defined here:
https://issues.apache.org/jira/browse/KAFKA-5266
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeqo/kafka feature/KAFKA-5266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3102
----
commit f0219737139760a455baf54bce6b1fa06789b255
Author: Jorge Quilcate Otoya <quilcate.jo...@gmail.com>
Date: 2017-05-19T14:40:15Z
implement improvements (1,2,3)
----
> Follow-up improvements for consumer offset reset tool (KIP-122)
> ---------------------------------------------------------------
>
> Key: KAFKA-5266
> URL: https://issues.apache.org/jira/browse/KAFKA-5266
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Jason Gustafson
> Assignee: Jorge Quilcate
> Fix For: 0.11.0.0
>
>
> 1. We should try to ensure that offsets are in range for the topic partition.
> We currently only verify this for the shift option.
> 2. If you provide a CSV file, you shouldn't need to specify one of the
> --all-topics or --topic options.
> 3. We currently support a "reset to current offsets" option if none of the
> supported reset options are provided. This seems kind of useless. Perhaps we
> should just enforce that one of the reset options is provided.
> 4. The command fails with an NPE if we cannot find one of the offsets we are
> trying to reset. It would be better to raise an exception with a friendlier
> message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
