[
https://issues.apache.org/jira/browse/KAFKA-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018106#comment-16018106
]
Jason Gustafson edited comment on KAFKA-5266 at 5/19/17 10:14 PM:
------------------------------------------------------------------
[~jeqo] Maybe it could be {{--to-current}}, which sort of fits with the
{{--to-offset}} option? On 4., filtering makes sense, but there will always be
some case where some error pops up when we actually try to collect the offsets
we want to commit. My point is just that we should raise a friendly error to
the user when that happens. So all of those paths where we currently pass
through null in {{prepareOffsetsToReset}} should raise some exception instead
with a nice message.
was (Author: hachikuji):
[~jeqo] Maybe it could be "--to-current," which sort of fits with the
"--to-offset" option? On 4., filtering makes sense, but there will always be
some case where some error pops up when we actually try to collect the offsets
we want to commit. My point is just that we should raise a friendly error to
the user when that happens. So all of those paths where we currently pass
through null in {{prepareOffsetsToReset}} should raise some exception instead
with a nice message.
> Follow-up improvements for consumer offset reset tool (KIP-122)
> ---------------------------------------------------------------
>
> Key: KAFKA-5266
> URL: https://issues.apache.org/jira/browse/KAFKA-5266
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Jason Gustafson
> Assignee: Jorge Quilcate
> Fix For: 0.11.0.0
>
>
> 1. We should try to ensure that offsets are in range for the topic partition.
> We currently only verify this for the shift option.
> 2. If you provide a CSV file, you shouldn't need to specify one of the
> --all-topics or --topic options.
> 3. We currently support a "reset to current offsets" option if none of the
> supported reset options are provided. This seems kind of useless. Perhaps we
> should just enforce that one of the reset options is provided.
> 4. The command fails with an NPE if we cannot find one of the offsets we are
> trying to reset. It would be better to raise an exception with a friendlier
> message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
