[ 
https://issues.apache.org/jira/browse/KAFKA-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022574#comment-16022574
 ] 

ASF GitHub Bot commented on KAFKA-5314:
---------------------------------------

GitHub user enothereska opened a pull request:

    https://github.com/apache/kafka/pull/3135

    KAFKA-5314: exception handling and cleanup for state stores

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/enothereska/kafka exceptions-stores-KAFKA-5314

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3135
    
----
commit 7be5deb1be681e7b6c2bae328379a1540d237bc9
Author: Eno Thereska <eno.there...@gmail.com>
Date:   2017-05-23T17:02:13Z

    Cleanup and fix pass I

commit 7a4e18a7ebfd1206433ea89c1879cc7c2afd2b83
Author: Eno Thereska <eno.there...@gmail.com>
Date:   2017-05-23T17:55:51Z

    Caching tests

commit c6f57b29d712916149a4264aab27973e764c83b5
Author: Eno Thereska <eno.there...@gmail.com>
Date:   2017-05-24T09:02:48Z

    Various fixes and cleanup

----


> Improve exception handling for state stores
> -------------------------------------------
>
>                 Key: KAFKA-5314
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5314
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>    Affects Versions: 0.11.0.0
>            Reporter: Eno Thereska
>            Assignee: Eno Thereska
>             Fix For: 0.11.0.0
>
>
> RocksDbStore.java throws a mix of exceptions like StreamsException and 
> ProcessorStateException. That needs to be made consistent. 
> Also the exceptions thrown are not documented in the KeyValueStore interface. 
> All the stores (RocksDb, InMemory) need to have consistent exception handling.
> Today a store error is fatal and halts the stream thread that is processing 
> the exceptions. We could explore alternatives, like haling part of the 
> topology that passes through that faulty store, i.e., failing tasks, not the 
> entire thread.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to