[
https://issues.apache.org/jira/browse/KAFKA-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023426#comment-16023426
]
ASF GitHub Bot commented on KAFKA-5017:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/3138
KAFKA-5017: Record batch first offset remains accurate after compaction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-5017
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3138
----
commit c24ba61c27abb12d86705b9f0c7e322e24cdf692
Author: Jason Gustafson <[email protected]>
Date: 2017-05-24T18:37:26Z
KAFKA-5017: Record batch first offset remains accurate after compaction
----
> Consider making baseOffset the first offset in message format v2
> ----------------------------------------------------------------
>
> Key: KAFKA-5017
> URL: https://issues.apache.org/jira/browse/KAFKA-5017
> Project: Kafka
> Issue Type: Sub-task
> Components: clients, core, producer
> Reporter: Ismael Juma
> Fix For: 0.11.0.0
>
>
> Currently baseOffset starts as the first offset of the batch. If the first
> record is removed by compaction, baseOffset doesn't change and it is no
> longer the same as the first offset of the batch. This is inconsistent with
> every other field in the record batch header and it seems like there is no
> longer a reason for this behaviour.
> We should consider simplifying the behaviour so that baseOffset is simply the
> first offset of the record batch. We need to do this before 0.11 or we
> probably won't be able to do it until the next message format version change.
> cc [~hachikuji]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
