[
https://issues.apache.org/jira/browse/KAFKA-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026073#comment-16026073
]
ASF GitHub Bot commented on KAFKA-5308:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/3152
KAFKA-5308: TC should handle UNSUPPORTED_FOR_MESSAGE_FORMAT in
WriteTxnMarker response
Return UNSUPPORTED_MESSAGE_FORMAT in handleWriteTxnMarkers when a topic is
not the correct message format.
Remove any TopicPartitions that have same error from those waiting for
markers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-5308
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3152
----
commit 53ec77f88ca5c7be1d4c1ec9332bd982599ab700
Author: Damian Guy <[email protected]>
Date: 2017-05-26T09:09:06Z
Return UNSUPPORTED_MESSAGE_FORMAT in handleWriteTxnMarkers when a topic is
not
the correct message format.
Remove such topicpartitions from those waiting for markers
----
> TC should handle UNSUPPORTED_FOR_MESSAGE_FORMAT in WriteTxnMarker response
> --------------------------------------------------------------------------
>
> Key: KAFKA-5308
> URL: https://issues.apache.org/jira/browse/KAFKA-5308
> Project: Kafka
> Issue Type: Sub-task
> Components: clients, core, producer
> Reporter: Jason Gustafson
> Assignee: Damian Guy
> Priority: Blocker
> Labels: exactly-once
> Fix For: 0.11.0.0
>
>
> It could be the case that one of the topics added to a transaction is on a
> lower message format version. Because of
> https://github.com/apache/kafka/pull/3118, the producer won't be able to send
> any data to that topic, but the TC will nevertheless try to write the
> commit/abort marker to the log. Like the Produce request, the WriteTxnMarker
> request should return the UNSUPPORTED_FOR_MESSSAGE_FORMAT error. Instead of
> retrying, we should log a warning and remove the partition from the set of
> partitions awaiting marker completion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
