GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3339
KAFKA-5275: AdminClient API consistency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-5275-admin-client-api-consistency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3339
----
commit 515037d6c8d37c4d088fd1d15b2275a609ac7e26
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-13T13:56:05Z
Publish javadoc for common.annotation package
It includes InterfaceStability annotation.
commit 51264deb6a49221d9d524896f91fd70af2439887
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-13T14:10:44Z
Clarify InterfaceStability
commit c5d77c5cb28bf5db2932c1862e0ff44c74513158
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-13T14:27:46Z
Various javadoc improvements to API classes in clients.admin
commit 57d83d031fee20ac4e988c75deb6870c0be8ed41
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-13T23:40:40Z
Revert assert change
commit d5a1bb479f968ee0da86542446befc7e4ea77019
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T00:06:20Z
Add javadoc to some classes in common
commit a5bb109c46f90f0a9aa7312b725bc8326feb17e2
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T00:31:51Z
More javadoc for common classes
commit baffc69ef6cbaf4d5b8478bef6a7cfc6fa639fed
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T00:33:26Z
Address review feedback
commit ac064599f1708ae8e7a1194922a138af92999d37
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T00:56:41Z
Document TopicPartitionInfo
commit 72a0010ad5a0ddd2b18e0c757c70a923e4876d8c
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T12:34:40Z
Document broker requirement for AdminClient methods
commit 1a65c1005c65d03196e3db2cee2387389940421c
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T14:38:06Z
Add InterfaceStability to more classes
commit bdf4d09b3139d13c215f5ec7faea30654aa6db34
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:11:04Z
Use List instead of NavigableMap for TopicDescription.partitions
commit 5d5bd02bfc7ef657514e3ffd3ccffab18957b486
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:11:37Z
Lists exposed by TopicPartitionInfo should be unmodifiable
commit f41a6651728eecc0f16bbe167aaf747dc29ed8a1
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:17:15Z
Rename TopicListing to TopicListItem
Listing doesn't seem to be the right term for
what it represents.
commit 5bfb60756deee38394fb00efb7dd2d5871edae95
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:18:31Z
Rename NewTopic.partitions to NewTopic.numPartitions
commit 89b88deafa9cadeef2c4f35f75bc0e0331cb2456
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:24:42Z
Replace `description` usage in `ListTopicsResult`
`ListTopicsResult` doesn't return `TopicDescription`
commit e75985e0a1b6fe40d3309d36bf17e84e856edbd8
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:36:24Z
Rename `results()` to `value()`
commit 93fa6cafc908958ab81f416a76e4d41c1dae28ed
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T13:43:36Z
Don't use JVM level asserts as they are not enabled by default
commit 50db3ccac1d168cc12109d99a5a3c40260c5b781
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T14:07:32Z
Make retries configurable
commit 8752681528573e937b7ab5c1c7c9548fa21cbf29
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T15:20:41Z
Consistent usage of prefix for boolean accessors
The other option is to remove all of the existing prefixes.
commit c55861a3461931d22e340d6b7af8eb4e17c7b51c
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-14T15:36:11Z
Use `null` for unknown controller or leader
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
