Hi Joel, Thanks for your comments.
To keep it consistent as well as clear my suggestion is to change the TopicCount to GlobalTopicCount. This makes it fairly consistent (if not completely) as well as makes it unambiguous in what it means. Dong, Let me know if this sounds good. Best, Abhishek On Mon, Jun 26, 2017 at 10:45 AM, Joel Koshy <jjkosh...@gmail.com> wrote: > +1 on the original KIP > I actually prefer TotalTopicCount because it makes it clearer that it is a > cluster-wide count. OfflinePartitionsCount is global to the cluster (but it > is fairly clear that the controller is SoT on that). TopicCount on the > other hand could be misread as a local count since PartitinCount, URP, are > all local counts. > > On Thu, Jun 22, 2017 at 9:20 AM, Abhishek Mendhekar < > abhishek.mendhe...@gmail.com> wrote: > > > Hi Kafka Dev, > > > > Below is the link to the update KIP proposal. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 168%3A+Add+TopicCount+metric+per+cluster > > > > Thanks, > > Abhishek > > > > On Wed, Jun 21, 2017 at 3:55 PM, Abhishek Mendhekar < > > abhishek.mendhe...@gmail.com> wrote: > > > > > Hi Dong, > > > > > > Thanks for the suggestion! > > > > > > I think TopicCount sounds reasonable to me and it definitely seems > > > consistent with the other metric names. I will update the proposal to > > > reflect this change. > > > > > > Thanks, > > > Abhishek > > > > > > On Wed, Jun 21, 2017 at 2:17 PM, Dong Lin <lindon...@gmail.com> wrote: > > > > > >> Hey Abhishek, > > >> > > >> I think the metric is useful. Sorry for being late on this. I am > > wondering > > >> if TopicCount is a better name than TotalTopicCount, given that we > > >> currently have metric with names OfflinePartitionsCount, LeaderCount, > > >> PartitionCount etc. > > >> > > >> Thanks, > > >> Dong > > >> > > >> On Fri, Jun 16, 2017 at 9:09 AM, Abhishek Mendhekar < > > >> abhishek.mendhe...@gmail.com> wrote: > > >> > > >> > Hi Kafka Dev, > > >> > > > >> > I created KIP-168 to propose adding a metric to emit total topic > count > > >> > in a cluster. The metric will be emited by the controller. > > >> > > > >> > The KIP can be found here > > >> > (https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >> > 168%3A+Add+TotalTopicCount+metric+per+cluster) > > >> > and the assciated JIRA improvement is KAFKA-5461 > > >> > (https://issues.apache.org/jira/browse/KAFKA-5461) > > >> > > > >> > Appreciate all the comments. > > >> > > > >> > Best, > > >> > > > >> > Abhishek > > >> > > > >> > > > > > > > > > > > > -- > > > Abhishek Mendhekar > > > abhishek.mendhe...@gmail.com | 818.263.7030 <(818)%20263-7030> > > > > > > > > > > > -- > > Abhishek Mendhekar > > abhishek.mendhe...@gmail.com | 818.263.7030 > > > -- Abhishek Mendhekar abhishek.mendhe...@gmail.com | 818.263.7030
