Thanks Ismael, AFAICT it is already a separate thread: http://mail-archives.apache.org/mod_mbox/kafka-dev/201707.mbox/%3ccajiktexrb1hbojrm7tmy1hdm_+t+psrz_6pawhnlbokp46o...@mail.gmail.com%3e
On Wed, 19 Jul 2017 at 23:24 Guozhang Wang <wangg...@gmail.com> wrote: > Per 1. I suggested exposing the constant since we are doing so for consumer > and producer configs prefix as well (CONSUMER_PREFIX, etc). > > Guozhang > > On Wed, Jul 19, 2017 at 6:01 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > Thanks for the KIP, Damian. +1 (binding). A couple of minor comments: > > > > 1. Do we need to expose the TOPIC_PREFIX constant? > > 2. The vote thread ended up inside the discuss thread in Gmail. It may be > > worth sending another email to make it clear that the vote is ongoing. > You > > can link back to this thread so that the existing votes are still > counted. > > > > Ismael > > > > On Mon, Jul 17, 2017 at 4:43 AM, Damian Guy <damian....@gmail.com> > wrote: > > > > > Hi, > > > > > > I'd like to kick off the vote for KIP-173: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 173%3A+Add+prefix+to+StreamsConfig+to+enable+setting+default+internal+ > > > topic+configs > > > > > > A PR for this can be found here: https://github.com/apache/ > > kafka/pull/3459 > > > > > > Thanks, > > > Damian > > > > > > > > > -- > -- Guozhang >
