GitHub user EtaCassiopeia opened a pull request:

    https://github.com/apache/kafka/pull/3744

    Add group-id to the metrics tags

    It is better to have group-id in the JMX metrics. It would improve 
debuggability of systems:
    
```kafka_consumer_consumer_fetch_manager_metrics_test_0_records_lag{client_id="consumer-1",group_id="group-1",instance="service:8080",job="prometheus"}```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EtaCassiopeia/kafka 0.11.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3744
    
----
commit 86dbbf73300e865b2a8f50f0f79272c3b64a94b9
Author: Mohsen Zainalpour <mohsen.zainalp...@veon.com>
Date:   2017-08-25T20:10:40Z

    Add group-id to the metrics tags

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to