GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3869
MINOR: Make the state change log more consistent
Use logIdent to achieve this.
Also fixed an issue where we were logging about replicas going offline with
an empty set of replicas (i.e. no replicas had gone offline so no need to
log).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka improve-state-change-log
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3869
----
commit a9e3c540a4bf480059678708701af3680da8a589
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-08-02T10:39:59Z
MINOR: Only log about marking replicas as offline if there is a replica
I noticed a bunch of these log messages with an empty set for the replicas.
commit c3cee6f9cbb16d9173fde25e28b4c7afb6383803
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-08-03T12:36:24Z
Use `logIdent` for more consistent state change logger
commit 3eaa96ed421f40a20a4a093a7e752c17de53d6f1
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-08-03T12:38:52Z
Remove duplication in `KafkaController` log messages
We were repeating information already available due to the `logIdent`.
commit 01a7d243501fb949e4825318431beafd1c33b051
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-08-03T12:43:07Z
Avoid unnecessary `toArray`
commit aa04ef55dbc0d1e362c042d605700fb222f6b065
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-09-15T01:45:24Z
Make it possible to add the controller epoch to the log prefix
commit 7c99c85947f04036d544025fc2b3c873198334c3
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-09-15T01:55:20Z
Share an instance of the underlying state change logger
commit d040105e629dcdf7770eb70e8b81bff02f0330d7
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-09-15T10:49:35Z
Logging consistency improvements
----
---
