GitHub user apurvam opened a pull request:
https://github.com/apache/kafka/pull/3896
KAFKA-5914 add message format version and message max bytes to metadata
response
Updated the `TopicResponse` part of the `MetadataResponse` to include the
message format version and the message max bytes.
One problem here is that we use the `TopicConfigHandler` to listen for
topic changes. However this is not invoked for topic _creates_ since the change
notification path is not updated during creates. I am not sure what the right
solution is here. Intuitively, we should update the the change notification
path for topic creates, but not sure if that has compatibility (or other)
implications.
TODO:
1. Add a more complete integration test where the client sends a real
`MetadataRequest` and receives the proper `MetadataResponse`.
2. Rebase to incorporate Jason's changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apurvam/kafka
KAFKA-5914-add-message-format-version-and-message-max-bytes-to-metadata-response
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3896
----
commit 7cc943c30be8bef4646580f19e5191ef7e476b98
Author: Apurva Mehta <[email protected]>
Date: 2017-09-19T04:29:00Z
Initial commit with a few tests
commit 5099d5163b071020cc627b6b0a7c4f388de99eaa
Author: Apurva Mehta <[email protected]>
Date: 2017-09-19T06:05:43Z
Added one more test
----
---
